BUG: fix parquet roundtrip with unsigned integer dtypes #31918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Bug
IO Parquet
TomAugspurger
approved these changes
Feb 12, 2020
|
thanks @jorisvandenbossche |
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 12, 2020
…d integer dtypes
jorisvandenbossche
added a commit
that referenced
this pull request
Feb 12, 2020
…dtypes (#31928) Co-authored-by: Joris Van den Bossche <[email protected]>
3 tasks
| @@ -103,6 +103,10 @@ def __from_arrow__( | |||
| import pyarrow # noqa: F811 | |||
| from pandas.core.arrays._arrow_utils import pyarrow_array_to_numpy_and_mask | |||
|
|
|||
| pyarrow_type = pyarrow.from_numpy_dtype(self.type) | |||
| if not array.type.equals(pyarrow_type): | |||
| array = array.cast(pyarrow_type) | |||
There was a problem hiding this comment.
this is the cause of a bunch of xfails in test_from_arrow_type_error. does this need to be tightened somehow, or is the test behavior not something we care about?
There was a problem hiding this comment.
It could be tightened, for example by checking that the array.type is integral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31896