Skip to content

BUG: using loc[int] with object index #31905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2020

Conversation

jbrockmendel
Copy link
Member

This causes us to raise KeyError instead of TypeError in a couple of places, consistent with #31867.

Also note this leaves us with only one non-plotting usage of holds_integer, and it wouldnt surprise me if that one is subtly causing problems too.

@jbrockmendel jbrockmendel added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Feb 12, 2020
@jreback jreback added this to the 1.1 milestone Feb 22, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note (maybe api breaking changes to raise visibility)

@jreback
Copy link
Contributor

jreback commented Feb 22, 2020

lgtm. merge on green.

@jbrockmendel jbrockmendel merged commit 020dcce into pandas-dev:master Feb 22, 2020
@jbrockmendel jbrockmendel deleted the 19456 branch February 22, 2020 17:53
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
* BUG: using loc[int] with object index

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using .loc[integer] with object Index (also) containing floats
2 participants