BUG: fix infer_dtype for StringDtype #31877
Conversation
jorisvandenbossche
added
Bug
Dtype Conversions
| def test_convert_string_dtype(self): | ||
| # https://github.com/pandas-dev/pandas/issues/31731 -> converting columns | ||
| # that are already string dtype | ||
| df = pd.DataFrame({"A": ["a", "b", "c"], "B": ["ä", "ö", "ü"]}, dtype="string") |
There was a problem hiding this comment.
can you parameterize using the nulls_fixture (and no null as you have now) as well
There was a problem hiding this comment.
we may want to have a null_fixture_for_strings e.g. [None, np.nan, pd.NA]
There was a problem hiding this comment.
There is no need to parametrize for nulls here, I think. I am creating this with dtype string, and once you have that dtype, there is no difference for different nulls. So it would be testing construction with different nulls, which isn't the goal here.
There was a problem hiding this comment.
are there other tests that convert_dtypes on strings with nulls?
There was a problem hiding this comment.
convert_dtypes doesn't care about nulls or not if the dtype is already "string".
But added one NA in the values.
|
Updated |
Closes #31731