CLN: Move info #31876
Merged
CLN: Move info #31876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Feb 11, 2020
MarcoGorelli
force-pushed
the
move-info
branch
from
44efd34 to
6641e2b
Compare
|
@MarcoGorelli can you merge master to resolve conflicts |
|
@simonjayhawkins sure, done |
jreback
requested changes
Feb 16, 2020
MarcoGorelli
force-pushed
the
move-info
branch
from
faf2252 to
b956d2a
Compare
|
Hello @MarcoGorelli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-18 10:21:23 UTC |
|
@jreback sure, have reverted renaming the fixture and have added type annotations |
jreback
requested changes
Feb 17, 2020
MarcoGorelli
force-pushed
the
move-info
branch
from
233f78c to
5597914
Compare
|
@jreback sure, have moved all imports to the top and have reverted moving the fixture |
jreback
approved these changes
Feb 19, 2020
|
thanks @MarcoGorelli move PRs have to be exactly a move only (and whatever fixes are needed in the target files to get green CI), otherwise very difficult / impossible to reveiw. |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precursor to xref #31796. Have moved
DataFrame.infocode intopandas/io/formats/info.py, along with tests