CLN: f-string formatting #31868
Merged
CLN: f-string formatting #31868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @monicaw218! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-11 04:36:39 UTC |
WillAyd
requested changes
Feb 11, 2020
| type(index).__name__.rstrip("Index") | ||
| ) | ||
| msg = f"Cannot cast {type(index).__name__.rstrip('Index')}.*? to " | ||
| # strip Index to convert PeriodIndex -> Period |
There was a problem hiding this comment.
I guess should move this comment before 1350 so it reads sequentially
There was a problem hiding this comment.
Thanks, I was wondering about this, too
|
Great thanks @monicaw218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref to #29547
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffReplacing strings interpolated with .format() with strings interpolated with f-strings