BUG: Fix rolling.corr with time frequency #31841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke can you rebase / merge on green. |
jreback
approved these changes
Feb 10, 2020
doc/source/whatsnew/v1.0.2.rst
Outdated
| @@ -17,6 +17,7 @@ Fixed regressions | |||
|
|
|||
| - Fixed regression in :meth:`DataFrame.to_excel` when ``columns`` kwarg is passed (:issue:`31677`) | |||
| - Fixed regression in :meth:`Series.align` when ``other`` is a DataFrame and ``method`` is not None (:issue:`31785`) | |||
| - Fixed regression in :meth:`pandas.core.window.Rolling.corr` when using a time offset (:issue:`31789`) | |||
There was a problem hiding this comment.
Suggested change
| - Fixed regression in :meth:`pandas.core.window.Rolling.corr` when using a time offset (:issue:`31789`) | |
| - Fixed regression in :meth:`rolling(..).corr() <pandas.core.window.Rolling.corr>` when using a time offset (:issue:`31789`) |
|
@meeseeksdev backport to 1.0.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Feb 19, 2020
* BUG: Fix rolling.corr with time frequency * Add extra tick in whatsnew * Clarify whatsnew
simonjayhawkins
pushed a commit
that referenced
this pull request
Feb 19, 2020
Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff