Skip to content

CI Fix w/o tm helper #31800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Feb 8, 2020

Alternate to #31791

@jbrockmendel
Copy link
Member

LGTM

@ShaharNaveh
Copy link
Member

ShaharNaveh commented Feb 8, 2020

TBH I am -1 on that, as we are trying to get rid of all the bare pytest raises.
maybe the name of external_error_raised is not good, and needs a different (and better) name.

As far as I know we are planning to have a CI check for no bare pytest raises, obviously there are some exceptions such as an external error message, we need to agree on how to mark bare pytest raises that are bare on purpose.

A conversion on that topic has been started at #30999 (comment)

@WillAyd
Copy link
Member Author

WillAyd commented Feb 8, 2020

@momisbestfriend the problem is that helper isn’t backported so can’t be used to fix CI

@jreback
Copy link
Contributor

jreback commented Feb 9, 2020

@MomIsBestFriend the problem is that helper isn’t backported so can’t be used to fix CI

we can simply backport the helper, no?

@WillAyd
Copy link
Member Author

WillAyd commented Feb 9, 2020

Sure that would be an alternative

@WillAyd
Copy link
Member Author

WillAyd commented Feb 12, 2020

Looks like the CI failures may have resolved themselves on the 1.0.x branch, so I guess no need to do this. However, should probably revert original PR then - @jbrockmendel do you agree? Something you have time to tackle?

@jbrockmendel
Copy link
Member

Something you have time to tackle?

I'm stretched pretty thin ATM. Won't hitting the green button here get the job done?

@WillAyd WillAyd mentioned this pull request Feb 12, 2020
@WillAyd
Copy link
Member Author

WillAyd commented Feb 14, 2020

Closing in favor of #31931

@WillAyd WillAyd closed this Feb 14, 2020
@WillAyd WillAyd deleted the no-test-error branch April 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants