Added pd.NA to nulls_fixture #31799
Merged
Added pd.NA to nulls_fixture #31799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Feb 8, 2020
pandas/tests/indexes/test_base.py
Outdated
| @@ -1964,6 +1967,9 @@ def test_isin_nan_common_float64(self, nulls_fixture): | |||
| pytest.skip("pd.NaT not compatible with Float64Index") | |||
|
|
|||
| # Float64Index overrides isin, so must be checked separately | |||
| if nulls_fixture is pd.NA: | |||
| pytest.xfail("Not sure how to handle with Float64Index?") | |||
There was a problem hiding this comment.
Not sure about this test. Maybe logical to support, though we also skip for pd.NaT atm
There was a problem hiding this comment.
I don't think we should support converting pd.NA into np.nan in creating a float index, since pd.NA and np.nan behave differently
|
Cool! Yes, I agree it's a good idea to add it, and skip for now where it is not yet supported |
|
should this use the dynamic-xfail pattern we've used elsewhere? +1 on the idea |
jreback
reviewed
Feb 9, 2020
| @@ -129,6 +129,10 @@ def test_compare_scalar_interval_mixed_closed(self, op, closed, other_closed): | |||
| def test_compare_scalar_na(self, op, array, nulls_fixture): | |||
| result = op(array, nulls_fixture) | |||
| expected = self.elementwise_comparison(op, array, nulls_fixture) | |||
|
|
|||
| if nulls_fixture is pd.NA: | |||
| pytest.xfail("assert_numpy_array_equal broken for pd.NA") | |||
There was a problem hiding this comment.
can you make an issue for this (and ref here)
jreback
added
Missing-data
This was referenced Feb 11, 2020
|
Opened issues where I think applicable and updated comments accordingly |
5 tasks
|
Any other feedback here? |
5 tasks
|
this is ok Assume u have opened an issue for the xfail u r adding |
|
Thanks all for feedback |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jorisvandenbossche
I think we should do this. Simply xfailed issues up for discussion on how to resolve