BUG: fix StringArray/PandasArray setitem with slice #31773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Bug
Indexing
| scalar_value = lib.is_scalar(value) | ||
|
|
||
| if not scalar_key and scalar_value: | ||
| key = np.asarray(key) |
There was a problem hiding this comment.
@TomAugspurger do you remember why this was needed?
(I can also do a and not isinstance(key, slice) to be more conservative, but can't directly come up with a reason to keep it)
jreback
requested changes
Feb 9, 2020
jreback
approved these changes
Feb 12, 2020
|
thanks! |
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 12, 2020
jorisvandenbossche
added a commit
that referenced
this pull request
Feb 12, 2020
…ce (#31923) Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31772