BUG: Fix the rename function for Series and DataFrame, #3165 #3175
+28
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1: After
rename
, thename
of theindex
is missing:Both
Series
andDataFrame
has the same problems. The reason is that we didn't set thename
of theindex
while reconstructing theDataFrame/Series
byrename
.Bug 2:
rename
cannot work for theMultiIndex
case, theindex
becomes tuples, thenames
of the index are goneThe missing name issue is same as Bug1. The original
rename
function convert the dict to the mapper function and map each tuple but not each index, and doesn't reconstruct it asMultiIndex
, so it becomes aIndex
with some tuples.Fix
I've fixed the above two bugs, the
rename
will also pass thename
of theindex
too, therename
mapper will go through each index for theMultiIndex
case now.I also added some test cases in
test_series.py
andtest_frame.py