Skip to content

REF: Index.get_value call self.get_loc instead of self._engine.get_loc #31713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 6, 2020
Merged

REF: Index.get_value call self.get_loc instead of self._engine.get_loc #31713

merged 16 commits into from
Feb 6, 2020

Conversation

jbrockmendel
Copy link
Member

This makes Index.get_value match ExtensionIndex.get_value, so we can remove the latter.

Along with implementing _should_fallback_to_positional, this allows us to rip out Float64Index.get_value.

@jbrockmendel
REF: call _maybe_cast_integer first
d3b361c
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
85a000e 
…t_loc-next
@jbrockmendel
revert non-central
3ba2833
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
465e3d7 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
cbfcec6 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
d3d09fd 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
2598531 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
834e73d 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
9dfe264 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
1c00f34 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
ba78e29 
…t_loc-next
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ge…
dae5ca9 
…t_loc-next
@jbrockmendel
REF: Index.get_value call self.get_loc instead of self._engine.get_loc
ad1c0f7
@jbrockmendel
fixup remove unused imports
16b064c
@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 5, 2020
WillAyd
WillAyd requested changes Feb 6, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit

@jreback jreback added this to the 1.1 milestone Feb 6, 2020
@jreback jreback merged commit e5c65bf into pandas-dev:master Feb 6, 2020
@jreback
Copy link
Contributor

jreback commented Feb 6, 2020

thanks

@jbrockmendel jbrockmendel deleted the get_loc-next branch February 6, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd requested changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd