Skip to content

BUG: Block.iget not wrapping timedelta64/datetime64 #31666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

jbrockmendel
Copy link
Member

- Fixed regression where setting :attr:`pd.options.display.max_colwidth` was not accepting negative integer. In addition, this behavior has been deprecated in favor of using ``None`` (:issue:`31532`)
- Fixed regression in objTOJSON.c fix return-type warning (:issue:`31463`)
- Fixed regression in :meth:`qcut` when passed a nullable integer. (:issue:`31389`)
- Fixed regression in assigning to a :class:`Series` using a nullable integer dtype (:issue:`31446`)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line may have caused the doc warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that was it

@TomAugspurger TomAugspurger added this to the 1.0.1 milestone Feb 4, 2020
@TomAugspurger TomAugspurger added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 4, 2020
@jreback
Copy link
Contributor

jreback commented Feb 5, 2020

k, i guess this was because we were always boxing

@jreback jreback merged commit 1996b17 into pandas-dev:master Feb 5, 2020
@jbrockmendel jbrockmendel deleted the 31649 branch February 5, 2020 00:28
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 1.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 5, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 1996b17599731b889895b0e1edf758588c068fbb
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #31666: BUG: Block.iget not wrapping timedelta64/datetime64'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-31666-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #31666 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_datetime returning numpy.datetime64
4 participants