CLN: MultiIndex.get_value is a hive of scum and villainy #31662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
reviewed
Feb 4, 2020
| @@ -405,7 +405,7 @@ def test_agg_misc(): | |||
| ] | |||
|
|
|||
| # passed lambda | |||
| for t in cases: | |||
| for i, t in enumerate(cases): | |||
There was a problem hiding this comment.
this was in debugging, thought i had reverted it, thanks for pointing it out
jreback
approved these changes
Feb 5, 2020
| # We allow tuples if they are hashable, whereas other Index | ||
| # subclasses require scalar. | ||
| # We have to explicitly exclude generators, as these are hashable. | ||
| raise InvalidIndexError(key) | ||
|
|
||
| def _try_mi(k): |
There was a problem hiding this comment.
should think about making try_mi non-nested (just for cleanliness), give it a better name and type in the future.
There was a problem hiding this comment.
yah there's plenty more to do here, but this is a big step
jreback
added
Clean
Indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will in turn allow for simplification for other code that has built up kludges around MultiIndex.get_value's behavior