Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API: allow step!=1 slice with IntervalIndex #31658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: allow step!=1 slice with IntervalIndex #31658
Changes from 12 commits
7a26837
b371805
b78c4c3
e3631d9
7949ffd
4c2e703
88a7ace
0da92c5
f833f7c
041edbc
a2eb9bb
6b97b09
abdbd76
a678ec2
2c684cc
e4cc38d
10165b4
8308eb8
2bffbda
0bdb7b5
adf0775
2744a4b
cf1a393
74a40ff
9a04d41
f6360a6
d636108
9222513
2a698c0
d18c7a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current error message I get is more comprehensible I think (with
s
from the tests here):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would test it where start and stop are also intervals.
And can you move it to the
test_loc_with_slices
a bit above that is testing slicing with Intervals ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is not out of scope, as that hits this path, and right now actually ensured there is a proper error message.