CLN: prelims for MultiIndex.get_value #31640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Clean
Indexing
|
needs a rebase, and now that I think about it, try_mi really should NOT be where it is, it actually should be a series method i think. |
I'm hoping we can get it into |
|
Closing in favor of #31736. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unravelling MultiIndex.get_value and get_loc is shaping up to be a PITA. This separates out the easiest parts of the get_value cleanup.
@TomAugspurger can you confirm that the change made here to the
__finalize__call is correct? If so, suggest a test?