Skip to content

Replace .format with f-strings #31627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Replace .format with f-strings #31627

wants to merge 12 commits into from

Conversation

leandermaben
Copy link
Contributor

@leandermaben leandermaben commented Feb 3, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Feb 3, 2020 •
edited
Loading

Hello @leandermaben! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-04 17:30:48 UTC

@alimcmaster1 alimcmaster1 added Clean Code Style Code style, linting, code_checks labels Feb 3, 2020
alimcmaster1
alimcmaster1 reviewed Feb 3, 2020
View reviewed changes
pandas/util/_print_versions.py Outdated
print("\nINSTALLED VERSIONS")
print("------------------")
for k, stat in sys_info:
print(tpl.format(k=k, stat=stat))
print(f"{k}:<{maxlen}: {stat}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this print the same as previous? Previous output has extra {}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I looked into it changed it.
This is my first time contributing so thanks for the feedback.

alimcmaster1
alimcmaster1 requested changes Feb 3, 2020
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@alimcmaster1 alimcmaster1 mentioned this pull request Feb 4, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 requested changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leandermaben @pep8speaks @alimcmaster1