Skip to content

BUG: qcut can fail for highly discontinuous data distributions #31626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

BUG: qcut can fail for highly discontinuous data distributions #31626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cbeae5
Fixed #15069
puneet29 Feb 2, 2020
f1b3eb9
Linted code
puneet29 Feb 3, 2020
7750f91
Updated patch
puneet29 Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pandas/core/reshape/tile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ def qcut(
else:
quantiles = q
bins = algos.quantile(x, quantiles)

fac, bins = _bins_to_cuts(
x,
bins,
Expand Down Expand Up @@ -388,7 +389,19 @@ def _bins_to_cuts(
f"You can drop duplicate edges by setting the 'duplicates' kwarg"
)
else:
bins = unique_bins
if len(unique_bins) == 1:
raise ValueError(
f"Bin edges must be unique: {repr(bins)}.\n"
)
bins[0] = bins[0] - 1
for i in range(1, len(bins)):
if i - 2 < 0:
bins[i] = np.nextafter(bins[i], bins[i] - 1)
else:
bins[i - 1] = (bins[i - 2] + bins[i]) / 2
unique_bins = algos.unique(bins)
if len(unique_bins) < len(bins) and len(bins) != 2:
bins = unique_bins

side = "left" if right else "right"
ids = ensure_int64(bins.searchsorted(x, side=side))
Expand Down