-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG accept and deprecate negative integer for max_colwidth #31569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you have an entry point in the documentation to add the removal of support for version 1.2, to ease the maintanance on your side? |
So from the tests failing it seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, ping when revised and green (also merge master).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. ping on green.
ping @jreback it's green :) |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
thanks @glemaitre |
@glemaitre if u want to do the manual back port above would be great |
I'll do that. |
this is now how pandas formally supports this. see pandas-dev/pandas#31569
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff