-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Backport PR #31545 on branch 1.0.x (BUG&TST: df.replace fail after converting to new dtype) #31555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #31545 on branch 1.0.x (BUG&TST: df.replace fail after converting to new dtype) #31555
Conversation
…ng to new dtype
I think need to back port #31484 first - @charlesdong1991 something you can do? |
never did that well, I could try @WillAyd |
i think i messed it up, have to close it, I would appreciate a lot if you could give some help or directly take it over. @WillAyd |
checkout the 1.0.x branch locally and cherry pick the squashed commit from your other PR on top of it. Then push to GitHub targeting the 1.0 branch instead of master |
thanks for quick reply! emm, thats basically what i did, but somehow got tons of other commits along with, not sure if the master branch i have locally is way ahead of 1.0.x? |
ahh!, get it! @WillAyd i accidentally merge master to 1.0.x , my bad, new PR is there! and looks good |
@charlesdong1991 can you rebase this (on this branch) |
yeah, i am pretty going nuts by an error, i
but i am 100% sure it is correct because i am using it to login/out my github account, any reason why this could happen? @jreback 🙏 |
pushed #31584 |
sorry for that, I still could not figure out the problem 😞 and thanks for getting this done @jreback |
Backport PR #31545: BUG&TST: df.replace fail after converting to new dtype