Skip to content

Backport PR #31545 on branch 1.0.x (BUG&TST: df.replace fail after converting to new dtype) #31555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #31545: BUG&TST: df.replace fail after converting to new dtype

@lumberbot-app lumberbot-app bot added this to the 1.0.1 milestone Feb 1, 2020
@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite labels Feb 1, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 2, 2020

I think need to back port #31484 first - @charlesdong1991 something you can do?

@charlesdong1991
Copy link
Member

charlesdong1991 commented Feb 2, 2020

never did that well, I could try @WillAyd

@charlesdong1991
Copy link
Member

i think i messed it up, have to close it, I would appreciate a lot if you could give some help or directly take it over. @WillAyd

@WillAyd
Copy link
Member

WillAyd commented Feb 2, 2020

checkout the 1.0.x branch locally and cherry pick the squashed commit from your other PR on top of it. Then push to GitHub targeting the 1.0 branch instead of master

@charlesdong1991
Copy link
Member

charlesdong1991 commented Feb 2, 2020

thanks for quick reply! emm, thats basically what i did, but somehow got tons of other commits along with, not sure if the master branch i have locally is way ahead of 1.0.x?

@charlesdong1991
Copy link
Member

ahh!, get it! @WillAyd i accidentally merge master to 1.0.x , my bad, new PR is there! and looks good

@charlesdong1991
Copy link
Member

#31562

@jreback
Copy link
Contributor

jreback commented Feb 2, 2020

@charlesdong1991 can you rebase this (on this branch)

@charlesdong1991
Copy link
Member

charlesdong1991 commented Feb 2, 2020

yeah, i am pretty going nuts by an error, i remote add the repo, and rebased on this branch, but when i am pushing the commits, get

remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/meeseeksmachine/pandas.git/'

but i am 100% sure it is correct because i am using it to login/out my github account, any reason why this could happen? @jreback 🙏

@jreback
Copy link
Contributor

jreback commented Feb 2, 2020

pushed #31584

@charlesdong1991
Copy link
Member

sorry for that, I still could not figure out the problem 😞 and thanks for getting this done @jreback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants