-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: parase_dates column is in dataframe (#31251) #31550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
cc64192
4808c16
07eda6a
d4d1e32
5b0fefa
149c772
cc1c406
ac61a8a
36f7e22
119360d
918cc48
84c01bc
b310ed9
8dfb549
120e9d9
f0f058f
d3c59e4
83e8389
9fb1f91
fb8aaa2
83f84ed
df5572c
26329fc
e2ae57c
db16a8f
000245a
aab9225
6d9ba2a
7880cf0
f6146a5
f878ddc
b678eca
b7d3d83
cf8c680
27f365d
64336ff
44782c0
abab307
c815ffa
a9d2450
a2721fd
14cd612
f75f115
9853d0e
4fa44b7
106ed85
06384b7
feee467
73ea6ca
01582c4
d28db65
3b2b0d3
79633f9
c3e32d7
1996b17
d3b7e64
678bfae
3a4c310
69fe3c0
1d5d5a3
a1e0752
531a430
8e47971
be9ee6d
bacd48b
f5409cb
d84f9eb
a89f7fd
2862b3d
9bfdb0d
42065cd
33e86bf
aa47971
236f7e6
881d0b7
c6c86dd
2f70e41
2f9a446
d73ded0
2bf618f
f0b00f8
e2a6f6b
0b6debf
cc4a3e9
daf5bb4
935b6f4
120f35f
a2a35a8
9ef92ee
808004a
31c1856
d0c84ce
ecc72f4
aa720d4
e5c65bf
e1ca66b
8aa2520
beb4859
fdba416
0d078c5
cf01369
4b142ef
6d3cc14
e2b47ce
0bfb8cb
ca84bd0
9cd1a30
8225c8b
63dc85e
29bd964
4d2e1cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1516,3 +1516,14 @@ def test_hypothesis_delimited_date(date_format, dayfirst, delimiter, test_dateti | |
|
||
assert except_out_dateutil == except_in_dateutil | ||
assert result == expected | ||
|
||
|
||
def test_missing_column(all_parsers): | ||
parser = all_parsers | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add the github issue number as a comment here? |
||
content = StringIO("time,val\n" "212.23, 32\n") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe that the CI will fail because, this string is not concatenated, can ou please concatenate them? |
||
date_cols = ["time"] | ||
msg = "'time' is not in list" | ||
with pytest.raises(ValueError, match=msg): | ||
parser.read_csv( | ||
content, sep=",", usecols=["val"], parse_dates=date_cols, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tied to the wording but I don’t think “is not in list” is super clear to the end user, so could improve a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had missed to check CParser, handled it now.