CLN: Replace isinstace(foo, Class) with isinstance(foo, ABCClass) #31535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jreback merged 1 commit into pandas-dev:master from ShaharNaveh:CLN-isinstance-ABC

Feb 1, 2020

Member

ShaharNaveh commented Feb 1, 2020 •

edited

Loading

ref Ensure isinstance checks use ABC classes where available #27353
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry


          CLN: Replace isinstace(foo, Class) with isinstance(foo, ABCClass)

b802cca

ShaharNaveh force-pushed the CLN-isinstance-ABC branch from 7ad46b9 to b802cca Compare

February 1, 2020 12:48

jreback added the Clean label

jreback added this to the 1.1 milestone

jreback merged commit 3ae1710 into pandas-dev:master

Contributor

jreback commented Feb 1, 2020

thanks @MomIsBestFriend

ShaharNaveh deleted the CLN-isinstance-ABC branch

February 1, 2020 15:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels