Skip to content

Unpin openpyxl #31525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2020
Merged

Unpin openpyxl #31525

merged 1 commit into from
Feb 2, 2020

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jan 31, 2020

I think we pinned this originally because of issues with 3.0.2 specifically, but looks like a newer version is available on conda

ref #30009

@WillAyd WillAyd added the CI Continuous Integration label Jan 31, 2020
@jbrockmendel
Copy link
Member

Could this become !=3.0.1 so we retain the knowledge that this one version is not supported

@WillAyd
Copy link
Member Author

WillAyd commented Feb 1, 2020

Thought about that but we don't do that for other packages do we?

@jbrockmendel
Copy link
Member

fair enough. LGTM

@jbrockmendel jbrockmendel self-requested a review February 1, 2020 23:42
@jbrockmendel
Copy link
Member

cc @datapythonista thoughts?

@jreback jreback added this to the 1.1 milestone Feb 2, 2020
@jreback jreback merged commit 83e8389 into pandas-dev:master Feb 2, 2020
@jreback
Copy link
Contributor

jreback commented Feb 2, 2020

thanks @WillAyd

@WillAyd WillAyd deleted the openpyxl-unpin branch April 7, 2020 14:43
@WillAyd WillAyd mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@WillAyd @jbrockmendel @jreback