Skip to content

BUG: non-iterable value in meta raise error in json_normalize #31524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Mar 11, 2020
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
24c3ede
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jan 14, 2020
dea38f2
fix issue 17038
charlesdong1991 Jan 14, 2020
cd9e7ac
revert change
charlesdong1991 Jan 14, 2020
e5e912b
revert change
charlesdong1991 Jan 14, 2020
2d21d1e
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 Jan 31, 2020
fcb4b80
fix uo
charlesdong1991 Jan 31, 2020
8ec4450
pep8
charlesdong1991 Jan 31, 2020
a33d05c
whatsnew
charlesdong1991 Jan 31, 2020
6bedc52
fix up
charlesdong1991 Feb 1, 2020
1f0f3bc
fixup
charlesdong1991 Feb 1, 2020
ce81951
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 Feb 2, 2020
5de348c
move around
charlesdong1991 Feb 2, 2020
3c38c48
better python
charlesdong1991 Feb 11, 2020
130d71b
fix conflict
charlesdong1991 Feb 11, 2020
3ef920f
fixup
charlesdong1991 Feb 11, 2020
0b46239
fixup
charlesdong1991 Feb 11, 2020
f25a4f4
rebase and fix conflict
charlesdong1991 Feb 16, 2020
6eee937
clearer python
charlesdong1991 Feb 23, 2020
d4d9218
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 Feb 23, 2020
a23eb2d
rebase and resolve conflict
charlesdong1991 Mar 4, 2020
4c5d61b
rename methods
charlesdong1991 Mar 4, 2020
9726014
change typing
charlesdong1991 Mar 4, 2020
67a43fe
fix annotation
charlesdong1991 Mar 4, 2020
392e3d1
change back to any
charlesdong1991 Mar 4, 2020
011dbb0
change back to scalar
charlesdong1991 Mar 4, 2020
3e74a3a
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 Mar 5, 2020
9476af7
fixup
charlesdong1991 Mar 10, 2020
c399983
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 Mar 10, 2020
6165467
add ignore type
charlesdong1991 Mar 10, 2020
7a20b8c
fix annotation
charlesdong1991 Mar 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.0.2.rst
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ Bug fixes
**I/O**

- Using ``pd.NA`` with :meth:`DataFrame.to_json` now correctly outputs a null value instead of an empty object (:issue:`31615`)
- Bug in :meth:`pandas.json_normalize` when value in meta path is not iterable (:issue:`31507`)
- Fixed pickling of ``pandas.NA``. Previously a new object was returned, which broke computations relying on ``NA`` being a singleton (:issue:`31847`)
- Fixed bug in parquet roundtrip with nullable unsigned integer dtypes (:issue:`31896`).

Expand Down
20 changes: 16 additions & 4 deletions pandas/io/json/_normalize.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@

from collections import defaultdict
import copy
from typing import Any, DefaultDict, Dict, Iterable, List, Optional, Union
from typing import DefaultDict, Dict, Iterable, List, Optional, Union

import numpy as np

from pandas._libs.writers import convert_json_to_lines
from pandas._typing import Scalar
from pandas.util._decorators import deprecate

import pandas as pd
Expand Down Expand Up @@ -226,14 +227,26 @@ def _json_normalize(
Returns normalized data with columns prefixed with the given string.
"""

def _pull_field(js: Dict[str, Any], spec: Union[List, str]) -> Iterable:
def _pull_field(js: Dict[str, Scalar], spec: Union[List, str]) -> Scalar:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def _pull_field(js: Dict[str, Scalar], spec: Union[List, str]) -> Scalar:
def _pull_field(js: Dict[str, Any], spec: Union[List, str]) -> Union[Scalar, Iterable]:

"""Internal function to pull field"""
result = js # type: ignore
if isinstance(spec, list):
for field in spec:
result = result[field]
else:
result = result[spec]
return result

def _pull_records(js: Dict[str, Scalar], spec: Union[List, str]) -> Iterable:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def _pull_records(js: Dict[str, Scalar], spec: Union[List, str]) -> Iterable:
def _pull_records(js: Dict[str, Any], spec: Union[List, str]) -> Iterable:

"""
Interal function to pull field for records, and similar to
_pull_field, but require to return Iterable. And will raise error
if has non iterable value.
"""
result = _pull_field(js, spec)

# GH 31507 GH 30145, if result is not Iterable, raise TypeError if not
# null, otherwise return an empty list
if not isinstance(result, Iterable):
if pd.isnull(result):
result = [] # type: ignore
Expand All @@ -242,7 +255,6 @@ def _pull_field(js: Dict[str, Any], spec: Union[List, str]) -> Iterable:
f"{js} has non iterable value {result} for path {spec}. "
"Must be iterable or null."
)

return result

if isinstance(data, list) and not data:
Expand Down Expand Up @@ -292,7 +304,7 @@ def _recursive_extract(data, path, seen_meta, level=0):
_recursive_extract(obj[path[0]], path[1:], seen_meta, level=level + 1)
else:
for obj in data:
recs = _pull_field(obj, path[0])
recs = _pull_records(obj, path[0])
recs = [
nested_to_record(r, sep=sep, max_level=max_level)
if isinstance(r, dict)
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/io/json/test_normalize.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,16 @@ def test_non_interable_record_path_errors(self):
with pytest.raises(TypeError, match=msg):
json_normalize([test_input], record_path=[test_path])

def test_meta_non_iterable(self):
# GH 31507
data = """[{"id": 99, "data": [{"one": 1, "two": 2}]}]"""

result = json_normalize(json.loads(data), record_path=["data"], meta=["id"])
expected = DataFrame(
{"one": [1], "two": [2], "id": np.array([99], dtype=object)}
)
tm.assert_frame_equal(result, expected)


class TestNestedToRecord:
def test_flat_stays_flat(self):
Expand Down