-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: non-iterable value in meta raise error in json_normalize #31524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 1314059
fix conflicts
charlesdong1991 8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 24c3ede
Merge remote-tracking branch 'upstream/master'
charlesdong1991 dea38f2
fix issue 17038
charlesdong1991 cd9e7ac
revert change
charlesdong1991 e5e912b
revert change
charlesdong1991 2d21d1e
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 fcb4b80
fix uo
charlesdong1991 8ec4450
pep8
charlesdong1991 a33d05c
whatsnew
charlesdong1991 6bedc52
fix up
charlesdong1991 1f0f3bc
fixup
charlesdong1991 ce81951
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 5de348c
move around
charlesdong1991 3c38c48
better python
charlesdong1991 130d71b
fix conflict
charlesdong1991 3ef920f
fixup
charlesdong1991 0b46239
fixup
charlesdong1991 f25a4f4
rebase and fix conflict
charlesdong1991 6eee937
clearer python
charlesdong1991 d4d9218
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 a23eb2d
rebase and resolve conflict
charlesdong1991 4c5d61b
rename methods
charlesdong1991 9726014
change typing
charlesdong1991 67a43fe
fix annotation
charlesdong1991 392e3d1
change back to any
charlesdong1991 011dbb0
change back to scalar
charlesdong1991 3e74a3a
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 9476af7
fixup
charlesdong1991 c399983
Merge remote-tracking branch 'upstream/master' into fix_issue_31507
charlesdong1991 6165467
add ignore type
charlesdong1991 7a20b8c
fix annotation
charlesdong1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3,11 +3,12 @@ | |||||
|
||||||
from collections import defaultdict | ||||||
import copy | ||||||
from typing import Any, DefaultDict, Dict, Iterable, List, Optional, Union | ||||||
from typing import DefaultDict, Dict, Iterable, List, Optional, Union | ||||||
|
||||||
import numpy as np | ||||||
|
||||||
from pandas._libs.writers import convert_json_to_lines | ||||||
from pandas._typing import Scalar | ||||||
from pandas.util._decorators import deprecate | ||||||
|
||||||
import pandas as pd | ||||||
|
@@ -226,14 +227,26 @@ def _json_normalize( | |||||
Returns normalized data with columns prefixed with the given string. | ||||||
""" | ||||||
|
||||||
def _pull_field(js: Dict[str, Any], spec: Union[List, str]) -> Iterable: | ||||||
def _pull_field(js: Dict[str, Scalar], spec: Union[List, str]) -> Scalar: | ||||||
"""Internal function to pull field""" | ||||||
result = js # type: ignore | ||||||
if isinstance(spec, list): | ||||||
for field in spec: | ||||||
result = result[field] | ||||||
else: | ||||||
result = result[spec] | ||||||
return result | ||||||
|
||||||
def _pull_records(js: Dict[str, Scalar], spec: Union[List, str]) -> Iterable: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
""" | ||||||
Interal function to pull field for records, and similar to | ||||||
_pull_field, but require to return Iterable. And will raise error | ||||||
if has non iterable value. | ||||||
""" | ||||||
result = _pull_field(js, spec) | ||||||
|
||||||
# GH 31507 GH 30145, if result is not Iterable, raise TypeError if not | ||||||
# null, otherwise return an empty list | ||||||
if not isinstance(result, Iterable): | ||||||
if pd.isnull(result): | ||||||
result = [] # type: ignore | ||||||
|
@@ -242,7 +255,6 @@ def _pull_field(js: Dict[str, Any], spec: Union[List, str]) -> Iterable: | |||||
f"{js} has non iterable value {result} for path {spec}. " | ||||||
"Must be iterable or null." | ||||||
) | ||||||
|
||||||
return result | ||||||
|
||||||
if isinstance(data, list) and not data: | ||||||
|
@@ -292,7 +304,7 @@ def _recursive_extract(data, path, seen_meta, level=0): | |||||
_recursive_extract(obj[path[0]], path[1:], seen_meta, level=level + 1) | ||||||
else: | ||||||
for obj in data: | ||||||
recs = _pull_field(obj, path[0]) | ||||||
recs = _pull_records(obj, path[0]) | ||||||
recs = [ | ||||||
nested_to_record(r, sep=sep, max_level=max_level) | ||||||
if isinstance(r, dict) | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.