REGR: Fixed slicing DatetimeIndex with date

[TomAugspurger]

Closes #31501

[jbrockmendel]

We don’t combine for get_loc right? Ok to fix regression, but we should deprecate for internal consistency

[jreback]

thanks @TomAugspurger

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 1.0.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 2495068adad8cd8b4c75fe1e6102a777f0c2e262

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #31521: REGR: Fixed slicing DatetimeIndex with date'

4. Push to a named branch :

git push YOURFORK 1.0.x:auto-backport-of-pr-31521-on-1.0.x

5. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #31521 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

[TomAugspurger]

Not sure how this and get_loc overlap, but this seems like generally useful behavior. If there aren’t any ambiguities then I’d say it’s worth supporting.

…

On Jan 31, 2020, at 17:53, jbrockmendel ***@***.***> wrote:  We don’t combine for get_loc right? Ok to fix regression, but we should deprecate for internal consistency — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[jorisvandenbossche]

@TomAugspurger this still needs a backport?

[jorisvandenbossche]

@meeseeksdev backport to 1.0.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 1.0.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 2495068adad8cd8b4c75fe1e6102a777f0c2e262

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #31521: REGR: Fixed slicing DatetimeIndex with date'

4. Push to a named branch :

git push YOURFORK 1.0.x:auto-backport-of-pr-31521-on-1.0.x

5. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #31521 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.