REGR: DataFrame.__setitem__(slice, val) is positional #31515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Jan 31, 2020
TomAugspurger
added
the
Indexing
|
The change that this reverts was unintentional (was a code-cleanup intended to remove accessing a private |
jorisvandenbossche
approved these changes
Jan 31, 2020
jorisvandenbossche
changed the title
Co-Authored-By: Joris Van den Bossche <[email protected]>
|
OK, will need a followup issue for that deprecation if you want to push for it. Let's give @jreback a chance to look, but this should be good to go. |
jreback
approved these changes
Feb 1, 2020
jreback
reviewed
Feb 1, 2020
| @@ -860,6 +860,15 @@ def test_fancy_getitem_slice_mixed(self, float_frame, float_string_frame): | |||
|
|
|||
| assert (float_frame["C"] == 4).all() | |||
|
|
|||
| def test_setitem_slice_position(self): | |||
There was a problem hiding this comment.
@jbrockmendel if you can also test (df[:4]) for example (can just target master is ok)
Closed
|
This still needs a backport? |
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 3, 2020
jorisvandenbossche
added a commit
that referenced
this pull request
Feb 3, 2020
…onal (#31618) Co-authored-by: jbrockmendel <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff