Skip to content

CLN: No need to use libindex.get_value_at #31506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 2, 2020
Merged

CLN: No need to use libindex.get_value_at #31506

merged 7 commits into from
Feb 2, 2020

Conversation

jbrockmendel
Copy link
Member

Made possible because Series._values returns DTA/TDA for datetime64/timedelta64.

WillAyd
WillAyd approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback jreback added this to the 1.1 milestone Feb 2, 2020
@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 2, 2020
@jreback jreback merged commit 7880cf0 into pandas-dev:master Feb 2, 2020
@jreback
Copy link
Contributor

jreback commented Feb 2, 2020

thanks, nice clean

@jbrockmendel jbrockmendel deleted the maybe_box branch February 2, 2020 23:19
@dhirschfeld dhirschfeld mentioned this pull request Feb 3, 2020
Merged
5 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd