Skip to content

TST: preserve dtypes on assignment #31483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2020
Merged

TST: preserve dtypes on assignment #31483

merged 1 commit into from
Feb 1, 2020

Conversation

prakhar987
Copy link
Contributor

@prakhar987 prakhar987 commented Jan 31, 2020 •
edited
Loading

@prakhar987
Copy link
Contributor Author

prakhar987 commented Jan 31, 2020 •
edited
Loading

Couldn't find any matching tests (some tests were close but mainly based on datetime).
Have added one. Didnt look deep into the issue since its already fixed

WillAyd
WillAyd approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jreback

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Jan 31, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jan 31, 2020
@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves labels Feb 1, 2020
@jreback jreback changed the title TST: added test to validate (#31340) TST: preserve dtypes on assignment Feb 1, 2020
@jreback jreback merged commit 149c772 into pandas-dev:master Feb 1, 2020
@jreback
Copy link
Contributor

jreback commented Feb 1, 2020

thanks @prakhar987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Bug: loc assignment results in wrong dtype
3 participants
@prakhar987 @jreback @WillAyd