-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REGR: Fix TypeError in groupby min / max of period column #31477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
18508e5
Add test
a8bc3a8
Check for period dtype
23b7ba6
Release note
46bb8dc
Blacken
fd0e79b
Get rid of comma
9f063b3
Move release note
f973037
Move test
fc301d6
Add frame test
2b26a5c
Merge branch 'master' into period-bug
a7b60ef
Add comment
6bba2f5
Merge branch 'master' into period-bug
e28bb0b
Merge branch 'master' into period-bug
61b1016
whatsnew
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2037,3 +2037,19 @@ def test_groupby_list_level(): | |
expected = pd.DataFrame(np.arange(0, 9).reshape(3, 3)) | ||
result = expected.groupby(level=[0]).mean() | ||
tm.assert_frame_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize("func", ["min", "max"]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should go to test_aggregate |
||
def test_groupby_aggregate_period(func): | ||
# GH 31471 | ||
groups = [1, 2] | ||
periods = pd.period_range("2020", periods=2, freq="Y") | ||
|
||
df = pd.DataFrame({"a": groups, "b": periods}) | ||
|
||
result = getattr(df.groupby("a")["b"], func)() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you also add a test for the version on the dataframe? (so without the |
||
|
||
idx = pd.Int64Index([1, 2], name="a") | ||
expected = pd.Series(periods, index=idx, name="b") | ||
|
||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to the 1.01 whatsnew file? (this is a regression)