Skip to content

BUG: PeriodIndex.is_monotonic with leading NaT #31437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2020
Merged

BUG: PeriodIndex.is_monotonic with leading NaT #31437

merged 4 commits into from
Jan 31, 2020

Conversation

jbrockmendel
Copy link
Member

Before long I expect to just have PeriodEngine subclass DatetimeEngine.

@jreback jreback added the Period Period data type label Jan 31, 2020
@jreback jreback added this to the 1.1 milestone Jan 31, 2020
@jreback
Copy link
Contributor

jreback commented Jan 31, 2020

lgtm. needs a rebase.

@jbrockmendel
Copy link
Member Author

rebased+green

@WillAyd WillAyd merged commit 8a33050 into pandas-dev:master Jan 31, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 31, 2020

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the pi-monotonic branch January 31, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Bug Period Period data type
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd