Skip to content

PERF: postpone imports in Index constructor #31423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2020
Merged

PERF: postpone imports in Index constructor #31423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52cba23
PERF: postpone imports in Index constructor
jorisvandenbossche Jan 29, 2020
dd6ee1b
added comments
TomAugspurger Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,6 @@ def __new__(
) -> "Index":

from pandas.core.indexes.range import RangeIndex
from pandas import PeriodIndex, DatetimeIndex, TimedeltaIndex
from pandas.core.indexes.numeric import Float64Index, Int64Index, UInt64Index
from pandas.core.indexes.interval import IntervalIndex
from pandas.core.indexes.category import CategoricalIndex

name = maybe_extract_name(name, data, cls)

Expand All @@ -296,10 +292,16 @@ def __new__(

# categorical
elif is_categorical_dtype(data) or is_categorical_dtype(dtype):
# Delay import for perf. https://github.com/pandas-dev/pandas/pull/31423
from pandas.core.indexes.category import CategoricalIndex

return CategoricalIndex(data, dtype=dtype, copy=copy, name=name, **kwargs)

# interval
elif is_interval_dtype(data) or is_interval_dtype(dtype):
# Delay import for perf. https://github.com/pandas-dev/pandas/pull/31423
from pandas.core.indexes.interval import IntervalIndex

closed = kwargs.pop("closed", None)
if is_dtype_equal(_o_dtype, dtype):
return IntervalIndex(
Expand All @@ -314,6 +316,9 @@ def __new__(
or is_datetime64_any_dtype(dtype)
or "tz" in kwargs
):
# Delay import for perf. https://github.com/pandas-dev/pandas/pull/31423
from pandas import DatetimeIndex

if is_dtype_equal(_o_dtype, dtype):
# GH#23524 passing `dtype=object` to DatetimeIndex is invalid,
# will raise in the where `data` is already tz-aware. So
Expand All @@ -328,6 +333,9 @@ def __new__(
return DatetimeIndex(data, copy=copy, name=name, dtype=dtype, **kwargs)

elif is_timedelta64_dtype(data) or is_timedelta64_dtype(dtype):
# Delay import for perf. https://github.com/pandas-dev/pandas/pull/31423
from pandas import TimedeltaIndex

if is_dtype_equal(_o_dtype, dtype):
# Note we can pass copy=False because the .astype below
# will always make a copy
Expand All @@ -338,6 +346,9 @@ def __new__(
return TimedeltaIndex(data, copy=copy, name=name, dtype=dtype, **kwargs)

elif is_period_dtype(data) or is_period_dtype(dtype):
# Delay import for perf. https://github.com/pandas-dev/pandas/pull/31423
from pandas import PeriodIndex

if is_dtype_equal(_o_dtype, dtype):
return PeriodIndex(data, copy=False, name=name, **kwargs).astype(object)
return PeriodIndex(data, dtype=dtype, copy=copy, name=name, **kwargs)
Expand All @@ -357,6 +368,13 @@ def __new__(

# index-like
elif isinstance(data, (np.ndarray, Index, ABCSeries)):
# Delay import for perf. https://github.com/pandas-dev/pandas/pull/31423
from pandas.core.indexes.numeric import (
Float64Index,
Int64Index,
UInt64Index,
)

if dtype is not None:
# we need to avoid having numpy coerce
# things that look like ints/floats to ints unless
Expand Down