BUG: preserve object dtype for Index set ops #31401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-index-wrap_setop_result
…f-index-wrap_setop_result
jreback
reviewed
Feb 1, 2020
| @@ -2566,6 +2567,7 @@ def _union(self, other, sort): | |||
| # worth making this faster? a very unusual case | |||
| value_set = set(lvals) | |||
| result.extend([x for x in rvals if x not in value_set]) | |||
| result = Index(result)._values # do type inference here | |||
There was a problem hiding this comment.
why does _wrap_setop_result not do this?
There was a problem hiding this comment.
ATM it does in a roundabout manner. Index._wrap_setop_result calls self._constructor, which is type(self) whereas the subclasses use _shallow_copy.
jreback
added
Dtype Conversions
jreback
approved these changes
Feb 2, 2020
| @@ -2566,6 +2567,7 @@ def _union(self, other, sort): | |||
| # worth making this faster? a very unusual case | |||
| value_set = set(lvals) | |||
| result.extend([x for x in rvals if x not in value_set]) | |||
| result = Index(result)._values # do type inference here | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be fine with coercing if we did it consistently, but ATM we behave differently for monotonic-increasing vs otherwise.