Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise error in read_csv when arguments header and prefix both are not None #31383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error in read_csv when arguments header and prefix both are not None #31383
Changes from 7 commits
c053a8f
071ba5b
ed8278e
7231f52
a5fb107
13d8644
a003c51
77c8ee0
39cd6d5
a2cb6a4
204dbc2
1bc350b
a03d5b5
cc1f6f8
5fc40bd
d962941
1f35f6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this testing to_csv or read_csv? Looks like it's in the to_csv file, but is testing read_csv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's testing read_csv that's a mistake in naming it.
But I actually tried putting this test in
pandas/tests/io/parser/test_common.py
. But the problem there is that all the tests useio.parsers.read_csv
there. Andio.parsers.read_csv
doesn't seem to be going intoCParserWrapper
. So I tried putting it here. But now I am putting it back intest_common.py
and will import thepandas.read_csv
there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take a look, please?