Skip to content

BUG/REG: multiindex nested tuples with duplicates #31358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

jbrockmendel
Copy link
Member

there is an underlying problem with MultiIndex.get_loc that needs to get worked out, but that's going to take a while. This fixes the reported regression.

@jbrockmendel jbrockmendel changed the title BUG/REF: multiindex nested tuples with duplicates BUG/REG: multiindex nested tuples with duplicates Jan 27, 2020
@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 27, 2020
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel can you assign the 1.0.0 milestone for these regression fixes?

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Jan 28, 2020
@jreback jreback merged commit 54a6490 into pandas-dev:master Jan 28, 2020
@jreback
Copy link
Contributor

jreback commented Jan 28, 2020

thanks @jbrockmendel

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 28, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 54a6490ed050a693f04c740af2dddbd2fd19c4e1
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #31358: BUG/REG: multiindex nested tuples with duplicates'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-31358-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #31358 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@jreback
Copy link
Contributor

jreback commented Jan 28, 2020

@jbrockmendel can you push a backport for this, didn't work automatically.

jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Jan 28, 2020
@jbrockmendel jbrockmendel deleted the bug-28361 branch January 28, 2020 02:15
TomAugspurger pushed a commit that referenced this pull request Jan 28, 2020
* BUG/REF: multiindex nested tuples with duplicates (#31358)
@dsaxton dsaxton mentioned this pull request Aug 26, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value assignment bug for multi-indexed dataframes in v1.0.0rc0
4 participants