Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Increased support for subclassed types. #31331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Increased support for subclassed types. #31331
Changes from 23 commits
bdafa80
43673b6
7f594b5
a278d38
b9cf60a
99742a0
b117276
20f9574
f0eaaa2
0393c5d
40f1ba7
979f3cc
a02cbf3
c926c9f
f28852e
67ccc7f
a298deb
570dc6d
e853d80
4e60f49
3f0d920
5794ffc
5072f9e
a25da2e
25b4dfb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like it can be parametrized+shared with test_idxmin. if there are any others that can be parametrized, pls give it a try