Skip to content

PERF: avoid copies if possible in fill_binop #31300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2020
Merged

PERF: avoid copies if possible in fill_binop #31300

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89adc9d
PERF: avoid copies if possible in fill_binop
jbrockmendel Jan 25, 2020
11bc745
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jan 25, 2020
f69e754
typo remove extra right
jbrockmendel Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions pandas/core/ops/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,19 +329,27 @@ def fill_binop(left, right, fill_value):

Notes
-----
Makes copies if fill_value is not None
Makes copies if fill_value is not None and NAs are present.
"""
# TODO: can we make a no-copy implementation?
if fill_value is not None:
left_mask = isna(left)
right_mask = isna(right)
left = left.copy()

right = right.copy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the right copy not be removed as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, will update


# one but not both
mask = left_mask ^ right_mask
left[left_mask & mask] = fill_value
right[right_mask & mask] = fill_value

if left_mask.any():
# Avoid making a copy if we can
left = left.copy()
left[left_mask & mask] = fill_value

if right_mask.any():
# Avoid making a copy if we can
right = right.copy()
right[right_mask & mask] = fill_value

return left, right


Expand Down