REF: combine all alignment into _align_method_FRAME #31288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Jan 24, 2020
Co-Authored-By: William Ayd <[email protected]>
Co-Authored-By: William Ayd <[email protected]>
|
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-24 19:59:03 UTC |
WillAyd
requested changes
Jan 24, 2020
pandas/core/ops/__init__.py
Outdated
| @@ -609,8 +609,25 @@ def _combine_series_frame(left, right, func, axis: int): | |||
| return left._construct_result(new_data) | |||
|
|
|||
|
|
|||
| def _align_method_FRAME(left, right, axis): | |||
| """ convert rhs to meet lhs dims if input is list, tuple or np.ndarray """ | |||
| def _align_method_FRAME(left, right, axis, flex: Optional[bool] = False, level: Optional[Label] = None): | |||
There was a problem hiding this comment.
Suggested change
| def _align_method_FRAME(left, right, axis, flex: Optional[bool] = False, level: Optional[Label] = None): | |
| def _align_method_FRAME(left, right, axis, flex: Optional[bool] = False, level: Optional[Level] = None): |
Sorry typo on previous; we actually have Level defined in pandas._typing already (probably need to import)
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts us within striking distance of de-duplicating _flex_comp_method_FRAME and _comp_method_FRAME, with _arith_method_FRAME not far behind