Skip to content

BUG: DatetimeIndex.get_loc/get_value raise InvalidIndexError #31257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2020
Merged

BUG: DatetimeIndex.get_loc/get_value raise InvalidIndexError #31257

merged 2 commits into from
Jan 24, 2020

Conversation

jbrockmendel
Copy link
Member

almost done with the get_value/get_loc methods

@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Jan 23, 2020
@jreback jreback added this to the 1.1 milestone Jan 23, 2020
@jreback
Copy link
Contributor

jreback commented Jan 23, 2020

needs a rebase. not user facing right?

@jbrockmendel
Copy link
Member Author

not user facing right?

technically get_loc is part of the Index api

@jreback jreback merged commit 0b0cd08 into pandas-dev:master Jan 24, 2020
@jreback
Copy link
Contributor

jreback commented Jan 24, 2020

ok, though I feel this needs more tests, but maybe just being paranoid

@jbrockmendel
Copy link
Member Author

ok, though I feel this needs more tests

yah, i spent most of yesterday trying to organize/flesh-out the index/indexing tests and it turned in to a yak-shaving kind of day. this is gonna be a marathon. xref #31241 #31193.

@jbrockmendel jbrockmendel deleted the ref-dti-get_loc branch January 24, 2020 00:31
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 7, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback