COMPAT: tzawareness behavior to be same as datetime #31239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._assert_tzawareness_compat(other) | ||
| if op not in [Py_EQ, Py_NE]: | ||
| self._assert_tzawareness_compat(other) | ||
|
|
There was a problem hiding this comment.
if we dont have tzawareness compat here, then eq should be False and ne should be True, i.e. dont just fall through to cmp_scalar here
|
BTW, i think once this is done we can get rid of some (all?) uses of comp_method_OBJECT_ARRAY |
added 4 commits
January 24, 2020 14:13
|
@MomIsBestFriend still active? Can you try to get CI passing? |
|
@WillAyd I don't know if this is still active, I am not totally familiar with the code base, and this might been not the right issue to take, might be out of my level, I think I'll close this, due to the fact I can't really solve it. sorry for the waste of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff