Skip to content

(Fixes CI) Replaced set comprehension with a generator #31229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

(Fixes CI) Replaced set comprehension with a generator #31229

merged 1 commit into from
Jan 23, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Jan 23, 2020 •
edited
Loading

@WillAyd WillAyd added the CI Continuous Integration label Jan 23, 2020
WillAyd
WillAyd approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ping on green

@WillAyd WillAyd added this to the 1.0.0 milestone Jan 23, 2020
@ShaharNaveh
Copy link
Member Author

ping @WillAyd

@WillAyd WillAyd merged commit 6f395ad into pandas-dev:master Jan 23, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 23, 2020

Thanks!

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 23, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 23, 2020
@ShaharNaveh @meeseeksmachine
Backport PR pandas-dev#31229: (Fixes CI) Replaced set comprehension w…
62fcd4b 
…ith a generator
WillAyd pushed a commit that referenced this pull request Jan 23, 2020
@meeseeksmachine @WillAyd
Backport PR #31229: (Fixes CI) Replaced set comprehension with a gene…
4992efd 
…rator (#31231)
@ShaharNaveh ShaharNaveh deleted the CI-generator-C412 branch January 24, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Lint issue with new version of flake8-comprehensions plugin
2 participants
@ShaharNaveh @WillAyd