WIP: TST: pass random names in tm.makeDateIndex #31227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just at a brief glance not all of the JSON formats preserve index names. Split is a particular example which came up in #17393 |
|
Just curious: what was the motivation for adding this? |
We are using these functions for fixtures that are aimed at trying to cover a wide swath of possible index objects, but are missing large parts of that space. |
gfyoung
reviewed
Jan 26, 2020
| @@ -520,7 +520,8 @@ def test_map_empty(self, index): | |||
| result = s.map({}) | |||
|
|
|||
| expected = pd.Series(np.nan, index=s.index) | |||
| tm.assert_series_equal(result, expected) | |||
| tm.assert_series_equal(result, expected, check_names=False) | |||
| # TODO: can we check names her? | |||
There was a problem hiding this comment.
Suggested change
| # TODO: can we check names her? | |
| # TODO: can we check names here? |
|
closing to clear the queue, will keep trimming away at these locally |
5 tasks
jbrockmendel
added
the
Mothballed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WillAyd nearly all of the remaining test failures locally are in the json tests. can you take a look and suggest whether we just need to pass
check_names=FalseI expect if we do something like this we won't want to actually randomize; that part I guess is a proof of concept for now.