Skip to content

Make DTI.get_loc/get_value require tzawareness-compat for datetimes #31194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Make DTI.get_loc/get_value require tzawareness-compat for datetimes #31194

wants to merge 4 commits into from

Conversation

jbrockmendel
Copy link
Member

jorisvandenbossche
jorisvandenbossche requested changes Jan 22, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we first further discuss this at #30994 ?

@jbrockmendel
Copy link
Member Author

Can we first further discuss this at #30994 ?

Discuss away

@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 4, 2020
@jbrockmendel
Copy link
Member Author

closing to clear the queue, will revisit

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Apr 21, 2020
@jbrockmendel jbrockmendel deleted the dti-get_loc-awareness branch November 8, 2021 16:35
@jbrockmendel jbrockmendel removed the Mothballed Temporarily-closed PR the author plans to return to label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche requested changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: DatetimeIndex.get_loc(datetime) should require tzawareness compat?
2 participants
@jbrockmendel @jorisvandenbossche