Skip to content

BUG: DatetimeIndex.snap incorrectly setting freq #31188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@WillAyd
Copy link
Member

WillAyd commented Jan 21, 2020

Sounds good though I think we want to deprecate this function? #27098

@jbrockmendel
Copy link
Member Author

though I think we want to deprecate this function

Yah, i think the argument was that round can do what it snap does, but there was a comment somewhere that this isnt quite accurate. Regardless, fixing the bug is worthwhile.

@jorisvandenbossche
Copy link
Member

Should infer the frequency in case the result is actually regular? (to keep the correct behavior for those cases)

@jbrockmendel
Copy link
Member Author

Should infer the frequency in case the result is actually regular? (to keep the correct behavior for those cases)

Either way I guess. I tend to prefer not inferring in most places.

@jreback jreback added Bug Frequency DateOffsets labels Jan 26, 2020
@jreback jreback added this to the 1.1 milestone Jan 26, 2020
@jreback jreback merged commit d12c2c6 into pandas-dev:master Jan 26, 2020
@jreback
Copy link
Contributor

jreback commented Jan 26, 2020

thanks

@jbrockmendel jbrockmendel deleted the bug-snap branch January 26, 2020 01:42
keechongtan added a commit to keechongtan/pandas that referenced this pull request Jan 27, 2020
…ndexing-1row-df

* upstream/master: (194 commits)
  DOC Remove Python 2 specific comments from documentation (pandas-dev#31198)
  Follow up PR: pandas-dev#28097 Simplify branch statement (pandas-dev#29243)
  BUG: DatetimeIndex.snap incorrectly setting freq (pandas-dev#31188)
  Move DataFrame.info() to live with similar functions (pandas-dev#31317)
  ENH: accept a dictionary in plot colors (pandas-dev#31071)
  PERF: add shortcut to Timestamp constructor (pandas-dev#30676)
  CLN/MAINT: Clean and annotate stata reader and writers (pandas-dev#31072)
  REF: define _get_slice_axis in correct classes (pandas-dev#31304)
  BUG: DataFrame.floordiv(ser, axis=0) not matching column-wise bheavior (pandas-dev#31271)
  PERF: optimize is_scalar, is_iterator (pandas-dev#31294)
  BUG: Series rolling count ignores min_periods (pandas-dev#30923)
  xfail sparse warning; closes pandas-dev#31310 (pandas-dev#31311)
  REF: DatetimeIndex.get_value wrap DTI.get_loc (pandas-dev#31314)
  CLN: internals.managers (pandas-dev#31316)
  PERF: avoid copies if possible in fill_binop (pandas-dev#31300)
  Add test for multiindex json (pandas-dev#31307)
  BUG: passing TDA and wrong freq to TimedeltaIndex (pandas-dev#31268)
  BUG: inconsistency between PeriodIndex.get_value vs get_loc (pandas-dev#31172)
  CLN: remove _set_subtyp (pandas-dev#31301)
  CI: Updated version of macos image (pandas-dev#31292)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Frequency DateOffsets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants