CLN: Make Series._values match Index._values

pandas/core/base.py

@@ -752,16 +752,7 @@ def array(self) -> ExtensionArray:
         [a, b, a]
         Categories (2, object): [a, b]
         """
-        # As a mixin, we depend on the mixing class having _values.
-        # Special mixin syntax may be developed in the future:
-        # https://github.com/python/typing/issues/246
-        result = self._values  # type: ignore
-        if isinstance(result, np.ndarray):
-            from pandas.core.arrays.numpy_ import PandasArray
-
-            result = PandasArray(result)
-
-        return result
+        raise AbstractMethodError(self)
 
     def to_numpy(self, dtype=None, copy=False, na_value=lib.no_default, **kwargs):
         """

pandas/core/construction.py

@@ -377,10 +377,7 @@ def extract_array(obj, extract_numpy: bool = False):
     array([1, 2, 3])
     """
     if isinstance(obj, (ABCIndexClass, ABCSeries)):
-        arr = obj._values
-        if not extract_numpy and isinstance(arr, np.ndarray):
-            return obj.array
-        return arr
+        obj = obj.array
 
     if extract_numpy and isinstance(obj, ABCPandasArray):
         obj = obj.to_numpy()

pandas/core/internals/blocks.py

@@ -67,7 +67,14 @@
 )
 
 import pandas.core.algorithms as algos
-from pandas.core.arrays import Categorical, DatetimeArray, PandasDtype, TimedeltaArray
+from pandas.core.arrays import (
+    Categorical,
+    DatetimeArray,
+    ExtensionArray,
+    PandasArray,
+    PandasDtype,
+    TimedeltaArray,
+)
 from pandas.core.base import PandasObject
 import pandas.core.common as com
 from pandas.core.construction import extract_array
@@ -210,6 +217,16 @@ def internal_values(self):
         """
         return self.values
 
+    def array_values(self) -> ExtensionArray:
+        """
+        The array that Series.array returns. Always an ExtensionArray.
+        """
+        return self._ea_values
+
+    @cache_readonly
+    def _ea_values(self) -> ExtensionArray:
+        return PandasArray(self.values)
+
     def get_values(self, dtype=None):
         """
         return an internal format, currently just the ndarray
@@ -1782,6 +1799,9 @@ def get_values(self, dtype=None):
             values = values.reshape((1,) + values.shape)
         return values
 
+    def array_values(self) -> ExtensionArray:
+        return self.values
+
     def to_dense(self):
         return np.asarray(self.values)
 
@@ -2123,12 +2143,15 @@ def get_values(self, dtype=None):
             return result.reshape(self.values.shape)
         return self.values
 
+    def array_values(self):
+        return self._ea_values
+
     def internal_values(self):
         return self._ea_values
 
     @cache_readonly
     def _ea_values(self):
-        return self._holder(self.values)
+        return self._holder._simple_new(self.values)
 
 
 class DatetimeBlock(DatetimeLikeBlockMixin, Block):
@@ -2166,7 +2189,6 @@ def _maybe_coerce_values(self, values):
             values = values._data
 
         assert isinstance(values, np.ndarray), type(values)
-        assert values.dtype == _NS_DTYPE, values.dtype
         return values
 
     def astype(self, dtype, copy: bool = False, errors: str = "raise"):

pandas/core/series.py

@@ -524,6 +524,11 @@ def _values(self):
         """
         return self._data.internal_values()
 
+    @Appender(base.IndexOpsMixin.array.__doc__)  # type: ignore
+    @property
+    def array(self) -> ExtensionArray:
+        return self._data._block.array_values()
+
     def _internal_get_values(self):
         """
         Same as values (but handles sparseness conversions); is a view.