Skip to content

DOC: fix DataFrame.plot docs #31167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

DOC: fix DataFrame.plot docs #31167

merged 1 commit into from
Jan 23, 2020

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jan 21, 2020 •
edited
Loading

@WillAyd
Copy link
Member

WillAyd commented Jan 21, 2020

@lithomas1 can you post a screenshot of how this looks after building?

@WillAyd WillAyd added the Docs label Jan 21, 2020
@lithomas1
Copy link
Member Author

image
cc @WillAyd
Should I add tests for this too in order to prevent regression in the future?

@lithomas1 lithomas1 marked this pull request as ready for review January 22, 2020 03:32
@lithomas1 lithomas1 requested a review from WillAyd January 22, 2020 03:32
@lithomas1 lithomas1 changed the title [WIP] DOC: fix DataFrame.plot docs DOC: fix DataFrame.plot docs Jan 22, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.0.0 milestone Jan 22, 2020
@TomAugspurger
Copy link
Contributor

Thanks. Let's merge this and see how they look when built.

@TomAugspurger TomAugspurger merged commit a43de44 into pandas-dev:master Jan 23, 2020
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 23, 2020
@lithomas1 @meeseeksmachine
Backport PR pandas-dev#31167: DOC: fix DataFrame.plot docs
955a323
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 23, 2020
Merged
TomAugspurger pushed a commit that referenced this pull request Jan 23, 2020
@meeseeksmachine @lithomas1 @TomAugspurger
Backport PR #31167: DOC: fix DataFrame.plot docs (#31244)
f55cedf 
Co-authored-by: Thomas Li <[email protected]>
@lithomas1 lithomas1 deleted the fix-plot-docs branch January 26, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

DataFrame.plot docs broken
4 participants
@lithomas1 @WillAyd @TomAugspurger @jorisvandenbossche