-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: replace long table of contents on home page with main links #31148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: replace long table of contents on home page with main links #31148
Conversation
+1 on this. |
@jorisvandenbossche proposal for the icons of the four items: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I think this is a great idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions on the card text.
@TomAugspurger thanks for the textual suggestions! |
Seems like an improvement, but the home of the docs is not linked from the website. And aftet the discussion we had on the PR to address that, its still unclear to me what vision we've got about the website. Feel free to merge, but personally I can't have an opinion on this without knowing what's the expected navigation. This feels right to me if we expect users to land in the home of the docs, and have the website as an addendum of the docs. If we have the website home as the home, and we expect people to navigate from there with the current navigation, I don't think this page will have visits, more than people in the docs looking for another section. Then it may be worth keeping all the subsections linked, and not add los of steps to go from one é page to another. |
Co-Authored-By: Tom Augspurger <[email protected]>
@datapythonista there are still plenty of ways to end up on the home page of the docs (eg googling "pandas docs", from links all over the internet, from clicking to the home page from somewhere else in the docs, ...), so personally, I think a more useful and better looking home page is an improvement anyway. |
Given the mostly positive comments here, going to merge this in a bit. |
+1 to merging. I don't suppose you've had a chance to check the PDF build with this 😄? I'm having trouble thinking through whether or not it'll be completely broken with these changes. |
Ah, good point ;) Let me try if |
I suppose that since we are currently using |
Right, to clarify I was mostly concerned about the toctree getting broken. But IIUC, this is not changing the actual sphinx toctree? |
Let's merge this and see how things look. I'll try out a PDF build once it's in. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
I was just checking, seems to be all fine |
Will do the backport |
This is a proposal to remove the long table of contents on the documentation home page and replace it with a highlight of the main parts of the documentation.
Reasons: I don't think the long table of contents resulted in a very attractive landing page of the docs. And further, it was also a "manual" table of contents which would therefore easily get out of date. And with the new content, we can also at the same time give some explanation on the organization of the docs.
So would like to get feedback on the general idea. The wording in the different boxes can certainly still be improved. And we could also make similar boxes to point to eg the installation guide or for the different "getting help" links.
It's using some bootstrap elements ("cards") that can be used now since the sphinx theme is based on bootstrap (and all credit to @stijnvanhoey for the html/css part, I re-used some content of what he worked on for the getting started guides, a PR for that is coming shortly). Screenshot of how it currently looks below, and a live version can be checked here: http://jorisvandenbossche.github.io/example-pandas-docs/html-doc-home/