-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Check for pyarrow not feather before pyarrow tests #31144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(read_/to_feather can only use pyarrow.feather, not feather-format feather)
Hello @rebecca-palmer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-21 22:13:53 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conceptually fine. we are running older arrows so may have to handle old / new error messages
The build failures were because my system quotes the filename in the error message and some of yours don't; should be fixed now. |
lgtm. ping on green. |
Versions of this error message from the failed CI runs: History: This test was added in #16523 (because read_msgpack was returning garbage instead of an exception), initially checking only the exception type. It began checking the error message in #24676 My latest version changes the pattern to "Failed to open local file.+does_not_exist.{fn_ext}.?, error: .*", i.e. gives up on matching the last part of the message. |
green @jreback |
thanks @rebecca-palmer very nice |
pandas now needs pyarrow.feather (not in Debian), not python3-feather-format, for read_feather/to_feather Author: Rebecca N. Palmer <[email protected]> Forwarded: accepted for 1.1 pandas-dev/pandas#31144 Gbp-Pq: Name pyarrow_feather.patch
read_feather/to_feather now use pyarrow.feather, not top-level (feather-format) feather, but some of their tests were still looking for top-level feather.
Two of them that deliberately cause a file not found error were also looking for the wrong form of error message. (Probably nobody noticed because the above was skipping them.)