ERR: better error message on unparseable datetimes #31118
Conversation
Signed-off-by: baevpetr <[email protected]>
Signed-off-by: baevpetr <[email protected]>
Signed-off-by: baevpetr <[email protected]>
|
So, Linux py36_minimum_versions & macOS py36_macos builds do not pass the test: |
|
@simonjayhawkins, no, I can't. Sorry. |
|
If you now unable to reinstate the original repository, then you should put a note in the original PR to make the reviewers of the original PR aware. To help maintain the history, should also update the OP to reference the previous PR. |
simonjayhawkins
added
Error Reporting
| # GH#10720 | ||
| date = "Month 1, 1999" | ||
| expected_args = ( | ||
| f"Unknown string format: %s {date}. " |
There was a problem hiding this comment.
I believe that the error is here, can you remove the %s?
There was a problem hiding this comment.
AssertionError: Pattern "Unknown string format: %s Month 1, 1999. You can coerce to NaT by passing errors='coerce'" not found in "Unknown string format. You can coerce to NaT by passing errors='coerce'"
That is output from tests on Linux py36_minimum_versions & macOS py36_macos. There's no date at all. On other platforms test passes.
| def test_to_datetime_unparseable_raise(self): | ||
| # GH#10720 | ||
| date = "Month 1, 1999" | ||
| expected_args = ( |
| @@ -110,6 +110,16 @@ def test_to_timedelta_invalid(self): | |||
| invalid_data, to_timedelta(invalid_data, errors="ignore") | |||
| ) | |||
|
|
|||
| # GH#10720 | |||
There was a problem hiding this comment.
timedeltas passes normally. What logic should I test? (for now moved that test to other tests with 'coerce').
jreback
changed the title
|
And suddenly |
Signed-off-by: baevpetr <[email protected]>
|
@baevpetr is this still active? Can you try to get CI green? |
|
Closing as stale but ping if you'd like to pick back up |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff