Skip to content

DOC: automatic 'end' year of copyright #31085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Jan 16, 2020

#31022 Updated it after nearly 6 years, I think this will update with each new merge, so that should not be a problem from now on, (I think)
cc (@datapythonista)

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, looks good to me.

In general I think it's better to import datetime, since when reading code datetime is ambiguous, but datetime.datetime is not. But not a big deal, we have imports like this everywhere in the code, just saying.

@WillAyd WillAyd added this to the 1.1 milestone Jan 16, 2020
@WillAyd WillAyd added the Docs label Jan 16, 2020
@WillAyd WillAyd merged commit 321bae6 into pandas-dev:master Jan 16, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 16, 2020

Thanks @MomIsBestFriend

@ShaharNaveh
Copy link
Member Author

Makes sense, looks good to me.

In general I think it's better to import datetime, since when reading code datetime is ambiguous, but datetime.datetime is not. But not a big deal, we have imports like this everywhere in the code, just saying.

Do you mind if I open a pull request addressing these?

@datapythonista
Copy link
Member

Better open an issue first, so there is some discussion and you see if there is agreement in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants