CLN: __all__ for core/index.py #31082
Conversation
pandas/core/index.py
Outdated
| "ensure_index", | ||
| "ensure_index_from_sequences", | ||
| "get_objs_combined_axis", | ||
| "_sparsify", |
There was a problem hiding this comment.
I don't think the private methods _new_Index and _sparsify should be in __all__. I guess they are being used by other modules, which shouldn't be the case.
I'm ok to merge it like this, if that's the case, but if you don't mind researching a bit, seeing where those are used, and adding at least a comment about this, that would be great.
I'd probably move these imports at the end, so they are separated from the rest.
|
this file is not used anywhere in the code base (AT ALL). Is it OK to removed it completely? I don't know if a month is a lot of time or not when it comes to API changes, if it's not a lot of time, then what is a good time span to give users a warn about API change before actually changing it? |
|
The CI is red, I guess the objects you removed were being imported somewhere. |
|
Looks like it failed before it began the tests, closing and reopening |
|
Sorry, assumed there were genuine test fails. The failure is a correct error now, you need to either remove |
|
This is a deprecated module that is being changed, that should not be used in pandas. So what is the rationale for this change? |
@jorisvandenbossche I just saw the |
|
OK, I wouldn't put effort in a deprecated / unused file, but too late I guess :-) Is there a general issue about such changes? |
That's exactly what I said, when I saw the deprecation message... only after I have made the changes :)
There isn't a "master issue" for it, it's something I started to do here and there since #30828 (comment) was pointed out. |
|
Yea I think since deprecated maybe not even worth touching this module so just closing this one out. But thanks as always @MomIsBestFriend |
|
Understandable :) |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff