Skip to content

CLN: Removed unused varibles from for loops #31059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

CLN: Removed unused varibles from for loops #31059

merged 1 commit into from
Jan 16, 2020

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jbrockmendel
Copy link
Member

Can we remove the cdef declarations for i?

@ShaharNaveh
Copy link
Member Author

Can we remove the cdef declarations for i?

@jbrockmendel No, There's is uses for it in some of the for-loops.

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 16, 2020
@WillAyd WillAyd merged commit 7eafd73 into pandas-dev:master Jan 16, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 16, 2020

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CLN-unused-vars-sas branch January 16, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaharNaveh @jbrockmendel @WillAyd @simonjayhawkins @datapythonista